aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjustdave%bugzilla.org <>2009-09-03 19:19:30 +0000
committerjustdave%bugzilla.org <>2009-09-03 19:19:30 +0000
commit95b30f4944f8b7cd7170d2f53af47a55c58261e9 (patch)
tree6bb9d598f445b3eeea5f017c8bc2762b23da07c0
parentBug 512616: "collapse/expand comment" removes css-class 'bz_comment_text' - P... (diff)
downloadbugzilla-95b30f4944f8b7cd7170d2f53af47a55c58261e9.tar.gz
bugzilla-95b30f4944f8b7cd7170d2f53af47a55c58261e9.tar.bz2
bugzilla-95b30f4944f8b7cd7170d2f53af47a55c58261e9.zip
Bug 513585: Don't trigger utf8 conversion just because there are VIEWs present in the database.
r=mkanat, a=mkanat
-rw-r--r--Bugzilla/DB/Mysql.pm6
1 files changed, 3 insertions, 3 deletions
diff --git a/Bugzilla/DB/Mysql.pm b/Bugzilla/DB/Mysql.pm
index 45e181d3f..01cd239d7 100644
--- a/Bugzilla/DB/Mysql.pm
+++ b/Bugzilla/DB/Mysql.pm
@@ -325,7 +325,7 @@ EOT
my @isam_tables;
foreach my $row (@$table_status) {
my ($name, $type) = @$row;
- push(@isam_tables, $name) if $type eq "ISAM";
+ push(@isam_tables, $name) if (defined($type) && $type eq "ISAM");
}
if(scalar(@isam_tables)) {
@@ -370,7 +370,7 @@ EOT
my @myisam_tables;
foreach my $row (@$table_status) {
my ($name, $type) = @$row;
- if ($type =~ /^MYISAM$/i
+ if (defined ($type) && $type =~ /^MYISAM$/i
&& !grep($_ eq $name, Bugzilla::DB::Schema::Mysql::MYISAM_TABLES))
{
push(@myisam_tables, $name) ;
@@ -674,7 +674,7 @@ EOT
my $utf_table_status =
$self->selectall_arrayref("SHOW TABLE STATUS", {Slice=>{}});
$self->_after_table_status([map($_->{Name}, @$utf_table_status)]);
- my @non_utf8_tables = grep($_->{Collation} !~ /^utf8/, @$utf_table_status);
+ my @non_utf8_tables = grep(defined($_->{Collation}) && $_->{Collation} !~ /^utf8/, @$utf_table_status);
if (Bugzilla->params->{'utf8'} && scalar @non_utf8_tables) {
print <<EOT;