diff options
| author |   Denis Paranichev <denis.paranichev@intel.com> | 2021-02-19 18:29:55 +0300 |
|---|---|---|
| committer |   Mikhail Dvorskiy <mikhail.dvorskiy@intel.com> | 2021-02-24 11:36:24 +0300 |
| commit | c578cf44d19c7aa670bb164249dc7e01daaad329 (patch) | |
| tree | 7296c0d9e0a6726f88140a6a5c822dc8ebc014c7 | |
| parent | Add _PSTL_PRAGMA_SIMD_ORDERED_MONOTONIC_2ARGS definition in case of the use o... (diff) | |
| download | llvm-project-c578cf44d19c7aa670bb164249dc7e01daaad329.tar.gz llvm-project-c578cf44d19c7aa670bb164249dc7e01daaad329.tar.bz2 llvm-project-c578cf44d19c7aa670bb164249dc7e01daaad329.zip | |
Remove explicit default copy constructor in copy_constructible_value_holder (#123)
* CTest: skipt test if return code is 77
* Supposed solution
* Erased explicit copy c'tor in copy_assignable_value_holder, added is_default_constructible check in iterators test
* Deleted extra changes
* Deleted extra changes
* Splited static_assert in two lines: bool expression and message
* Splited assert in two lines
* Use shorter static_assert version with using
* Inserted spaces where it needs
* Reverted test calls and clarified commentaries
| -rw-r--r-- | include/oneapi/dpl/pstl/tuple_impl.h | 2 | ||||
| -rw-r--r-- | test/parallel_api/iterator/iterators.pass.cpp | 3 |
2 files changed, 2 insertions, 3 deletions
diff --git a/include/oneapi/dpl/pstl/tuple_impl.h b/include/oneapi/dpl/pstl/tuple_impl.h index 03dd9bd2c3ee..a63eb55f18ac 100644 --- a/include/oneapi/dpl/pstl/tuple_impl.h +++ b/include/oneapi/dpl/pstl/tuple_impl.h @@ -233,8 +233,6 @@ template <typename _Tp> struct __copy_assignable_holder<_Tp, false> : __value_holder<_Tp> { using __value_holder<_Tp>::__value_holder; - - __copy_assignable_holder(const __copy_assignable_holder& other) = default; __copy_assignable_holder& operator=(const __copy_assignable_holder& other) { diff --git a/test/parallel_api/iterator/iterators.pass.cpp b/test/parallel_api/iterator/iterators.pass.cpp index 11ddd6b56626..2b815afb5249 100644 --- a/test/parallel_api/iterator/iterators.pass.cpp +++ b/test/parallel_api/iterator/iterators.pass.cpp @@ -162,9 +162,10 @@ void test_explicit_move(InputIterator i, InputIterator j) { struct test_zip_iterator { template <typename T1, typename T2> void operator()(::std::vector<T1>& in1, ::std::vector<T2>& in2) { - //test that zip_iterator is default constructible + //runtime call to check default constructor and increase code coverage oneapi::dpl::zip_iterator<decltype(in1.begin()), decltype(in2.begin())> b; + //runtime call to check copy assignable operator and increase code coverage b = oneapi::dpl::make_zip_iterator(in1.begin(), in2.begin()); auto e = oneapi::dpl::make_zip_iterator(in1.end(), in2.end()); |