From ed727d30df105b6852f5118baa5a454965b6f4ba Mon Sep 17 00:00:00 2001 From: Mart Raudsepp Date: Sun, 22 Jan 2017 14:07:48 +0200 Subject: sync: Use dict comprehension in sync_categories as well --- backend/lib/sync.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/backend/lib/sync.py b/backend/lib/sync.py index dbb44c2..c837c23 100644 --- a/backend/lib/sync.py +++ b/backend/lib/sync.py @@ -117,10 +117,8 @@ def sync_categories(): data = http_session.get(url) # TODO: Handle response error (if not data) categories = data.json() - existing_categories = {} # TODO: Use UPSERT instead (on_conflict_do_update) if we can rely on postgresql:9.5 - for cat in Category.query.all(): - existing_categories[cat.name] = cat + existing_categories = {cat.name: cat for cat in Category.query.all()} for category in categories: if category['name'] in existing_categories: existing_categories[category['name']].description = category['description'] -- cgit v1.2.3-65-gdbad