From b60c7c57c227d326bb23c6c96e61cf6702a09ce5 Mon Sep 17 00:00:00 2001 From: root Date: Mon, 10 Aug 2009 17:09:56 -0400 Subject: Remove build- prefix from completed builds; todo --- frontend/pages/builds/download.php | 2 +- frontend/pages/upload.php | 4 ++-- todo | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/frontend/pages/builds/download.php b/frontend/pages/builds/download.php index 759b5c4..f472046 100644 --- a/frontend/pages/builds/download.php +++ b/frontend/pages/builds/download.php @@ -17,7 +17,7 @@ function init_builds_download(&$S) { debug('builds_download', 'Permission denied'); return '404'; } - $files=glob(COMPLETED.'/build-'.$build->id.'.*'); + $files=glob(COMPLETED.'/'.$build->id.'.*'); if (count($files)) { if (count($files) > 1) { debug('builds_download', 'extraneous file(s) found - don\'t know which to give them'); diff --git a/frontend/pages/upload.php b/frontend/pages/upload.php index d8dd4ec..a854199 100644 --- a/frontend/pages/upload.php +++ b/frontend/pages/upload.php @@ -24,10 +24,10 @@ function body_upload(&$S) { debug('upload', 'Got uploaded file '.$_FILES['file']['name'].' at '.$_FILES['file']['tmp_name']); $name=basename($_FILES['file']['name']); $ext=substr($name, strpos($name, '.')); - debug('upload', $_FILES['file']['tmp_name'].' -> '.COMPLETED."/build-$build->id$ext"); + debug('upload', $_FILES['file']['tmp_name'].' -> '.COMPLETED."/$build->id$ext"); if (!is_writable(COMPLETED)) die('No write permissions'); - if (!move_uploaded_file($_FILES['file']['tmp_name'], COMPLETED."/build-$build->id$ext")) + if (!move_uploaded_file($_FILES['file']['tmp_name'], COMPLETED."/$build->id$ext")) die('Move file failed'); echo 'Upload successful'; } diff --git a/todo b/todo index f1381e4..7354cd0 100644 --- a/todo +++ b/todo @@ -3,9 +3,9 @@ Add a profiles management page/backend utility Add cleanup functions to the frontend and backend (tasks dir in backend containing scripts that can be launched through frontend) *** Move bundler selection out of gentoo module *** Only offer bundlers that will work - profiles without CD in map file can't make livecd, installcd, etc. + Allow user to select if visible to the public Allow config viewing for builds, not just configurations -Add `flags` column to configurations, builds, use it to implement public and private things -Add safe shutdown to backend so it will stop once it gets to the end of a step that can be resumed +Change `visibility` columns to `flags` in configurations, builds for expandability Add build->configuration and configuration duplication Consider adding `configuration` col to builds Add map file for liveCD, load it into DB, etc. (currently hardcoded = evil) -- cgit v1.2.3-65-gdbad