aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJim Meyering <meyering@redhat.com>2010-03-24 09:05:27 +0100
committerJim Meyering <meyering@redhat.com>2010-03-24 09:23:01 +0100
commitca7db6cb8000cc283fcee7899140d2fc892b0296 (patch)
treed260953db3d8f737687ea424ea38d3675c5361b0 /tests/schematestutils.sh
parenttests: Don't add extra padding if counter mod 40 is 0 (diff)
downloadlibvirt-ca7db6cb8000cc283fcee7899140d2fc892b0296.tar.gz
libvirt-ca7db6cb8000cc283fcee7899140d2fc892b0296.tar.bz2
libvirt-ca7db6cb8000cc283fcee7899140d2fc892b0296.zip
tests: shell script portability and clean-up
* tests/test-lib.sh: "echo -n" is not portable. Use printf instead. Remove unnecessary uses of "eval-in-subshell" (subshell is sufficient). Remove uses of tests' -a operator; it is not portable. Instead, use "test cond && test cond2". * tests/schematestutils.sh: Replace use of test's -a.
Diffstat (limited to 'tests/schematestutils.sh')
-rw-r--r--tests/schematestutils.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/schematestutils.sh b/tests/schematestutils.sh
index 301b9ebc6..f1728578e 100644
--- a/tests/schematestutils.sh
+++ b/tests/schematestutils.sh
@@ -21,7 +21,7 @@ do
ret=$?
test_result $n $(basename $(dirname $xml))"/"$(basename $xml) $ret
- if test "$verbose" = "1" -a $ret != 0 ; then
+ if test "$verbose" = "1" && test $ret != 0 ; then
echo -e "$cmd\n$result"
fi
if test "$ret" != 0 ; then