aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authortravis%sedsystems.ca <>2005-03-10 00:18:03 +0000
committertravis%sedsystems.ca <>2005-03-10 00:18:03 +0000
commit672d71471ee2ddae6005a9259789899c41264823 (patch)
treeaac906cd42b2873fca45baeff2a1100b321b70ac /attachment.cgi
parentBug 284991 : small typo: "thisbug" should be two words (diff)
downloadbugzilla-672d71471ee2ddae6005a9259789899c41264823.tar.gz
bugzilla-672d71471ee2ddae6005a9259789899c41264823.tar.bz2
bugzilla-672d71471ee2ddae6005a9259789899c41264823.zip
Bug 282574 : use the new "auth_failure" error message for all authentication failures
Patch by Frederic Buclin <LpSolit@gmail.com> r=travis, wurblzap a=myk
Diffstat (limited to 'attachment.cgi')
-rwxr-xr-xattachment.cgi7
1 files changed, 4 insertions, 3 deletions
diff --git a/attachment.cgi b/attachment.cgi
index 64e30f64a..5e4c520f5 100755
--- a/attachment.cgi
+++ b/attachment.cgi
@@ -204,9 +204,10 @@ sub validateID
# Make sure the user is authorized to access this attachment's bug.
($bugid, my $isprivate) = FetchSQLData();
ValidateBugID($bugid);
- if (($isprivate > 0 ) && Param("insidergroup") &&
- !(UserInGroup(Param("insidergroup")))) {
- ThrowUserError("attachment_access_denied");
+ if ($isprivate && Param("insidergroup")) {
+ UserInGroup(Param("insidergroup"))
+ || ThrowUserError("auth_failure", {action => "access",
+ object => "attachment"});
}
# XXX shim code, kill $::FORM