aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormkanat%kerio.com <>2005-08-09 12:58:58 +0000
committermkanat%kerio.com <>2005-08-09 12:58:58 +0000
commit42a0e99d5c916b4123719d7a362e12e65e15fc2f (patch)
tree4f93a13b5360e7621601384e04e70dc455ff0c46 /editvalues.cgi
parentBug 285700: bump minimum File::Spec version to 0.84 to deal with taint errors (diff)
downloadbugzilla-42a0e99d5c916b4123719d7a362e12e65e15fc2f.tar.gz
bugzilla-42a0e99d5c916b4123719d7a362e12e65e15fc2f.tar.bz2
bugzilla-42a0e99d5c916b4123719d7a362e12e65e15fc2f.zip
Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave
Diffstat (limited to 'editvalues.cgi')
-rwxr-xr-xeditvalues.cgi8
1 files changed, 4 insertions, 4 deletions
diff --git a/editvalues.cgi b/editvalues.cgi
index cd73daeab..897498db3 100755
--- a/editvalues.cgi
+++ b/editvalues.cgi
@@ -39,14 +39,14 @@ our @valid_fields = ('op_sys', 'rep_platform', 'priority', 'bug_severity',);
######################################################################
# Returns whether or not the specified table exists in the @tables array.
-sub FieldExists ($) {
+sub FieldExists {
my ($field) = @_;
return lsearch(\@valid_fields, $field) >= 0;
}
# Same as FieldExists, but emits and error and dies if it fails.
-sub FieldMustExist ($) {
+sub FieldMustExist {
my ($field)= @_;
$field ||
@@ -58,7 +58,7 @@ sub FieldMustExist ($) {
}
# Returns if the specified value exists for the field specified.
-sub ValueExists ($$) {
+sub ValueExists {
my ($field, $value) = @_;
FieldMustExist($field);
trick_taint($field);
@@ -75,7 +75,7 @@ sub ValueExists ($$) {
}
# Same check as ValueExists, emits an error text and dies if it fails.
-sub ValueMustExist ($$) {
+sub ValueMustExist {
my ($field, $value)= @_;
# Values may not be empty (it's very difficult to deal