Some QA on quoting and ebuild style

Package-Manager: portage-2.2.0_alpha4/cvs/Linux x86_64

5 files changed, 21 insertions, 16 deletions

diff --git a/media-gfx/povray/ChangeLog b/media-gfx/povray/ChangeLog
index d909b90029fa..f83df5fbbd21 100644
--- a/media-gfx/povray/ChangeLog
+++ b/media-gfx/povray/ChangeLog
@@ -1,6 +1,10 @@
 # ChangeLog for media-gfx/povray
 # Copyright 1999-2010 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/media-gfx/povray/ChangeLog,v 1.106 2010/11/14 14:36:43 jlec Exp $
+# $Header: /var/cvsroot/gentoo-x86/media-gfx/povray/ChangeLog,v 1.107 2010/11/14 14:40:52 jlec Exp $
+
+  14 Nov 2010; Justin Lecher <jlec@gentoo.org> povray-3.6.1-r4.ebuild,
+  povray-3.7.0_beta35.ebuild, povray-3.7.0_beta38.ebuild:
+  Some QA on quoting and ebuild style
 
   14 Nov 2010; Justin Lecher <jlec@gentoo.org> povray-3.7.0_beta38.ebuild:
   Fix for compilation on prefix
diff --git a/media-gfx/povray/Manifest b/media-gfx/povray/Manifest
index ad77c755e0c7..a74e131a826b 100644
--- a/media-gfx/povray/Manifest
+++ b/media-gfx/povray/Manifest
@@ -12,15 +12,15 @@ AUX povray-3.7.0_beta38-print-extend-expiration-info.patch 680 RMD160 6fcdbfbd0e
 DIST povray-3.6.1.tar.bz2 8200160 RMD160 84ba679da66089f192cc1bfcf8bdd498e736a9a3 SHA1 1fab3ccbdedafbf77e3a66087709bbdf60bc643d SHA256 4e8a7fecd44807343b6867e1f2440aa0e09613d6d69a7385ac48f4e5e7737a73
 DIST povray-3.7.0.beta.35a.tar.bz2 6327923 RMD160 8dc45ebece731b081ddb7e5280862b40db9f63a3 SHA1 79d2c17d50efea00a509a3020f93668c727aa232 SHA256 4ec857bebf75895dcbc01ad455cd2192c1ccece786691ce9e4f8265c479cfb30
 DIST povray-3.7.0.beta.38.tar.bz2 6349534 RMD160 07f810d5a3e6a84caa14b7a0b56700c99d368d86 SHA1 0fe85371b17ca2c6242c2ad8bdc4ef8baaa42fd5 SHA256 3ffa272cd9e99efe9c12f5da0df00a8728b5d85a604b767f52d312903cfd0899
-EBUILD povray-3.6.1-r4.ebuild 2877 RMD160 5275cde4fa4022bd6decb8f83de39133a7475b4f SHA1 33b594a1eaf66265f0d0ccae4111e569a65b717e SHA256 fbbd1017316a24a8221e3f897a8fc1a2ab970f9b1655bd7f184f70ff69bb547f
-EBUILD povray-3.7.0_beta35.ebuild 4530 RMD160 d930855f7ea5e02e7c2b9ae0f8376cc2a4e092d4 SHA1 f22ba0a954e25c6c10a00281dcc51ed9242cb288 SHA256 5768b473ff895c47334c410e1fc8dd63ce62c45ad4a9cdabad4905e252ce758f
-EBUILD povray-3.7.0_beta38.ebuild 4529 RMD160 a011c3c7708e443c30c9db9c9c70783751df1d51 SHA1 76c47243a83b3f0dbbbabada9b10ad562e0a48ab SHA256 19ae8de0d9e323157043bddf0aab5e530316a7514a9ef3e36cdf7ab7cdd6e5c3
-MISC ChangeLog 16110 RMD160 5d3c5b2b4df4ba6606869e3d136e213861a30f7f SHA1 0c71aa89e868346387a6cb386adea278a2931771 SHA256 a5556bc15fd14a805e53913aee5901545b250fe2827f73dfabd730454ac32b3e
+EBUILD povray-3.6.1-r4.ebuild 2886 RMD160 7e4894d4df32972a06d8ead9471389b007892429 SHA1 5a08380ac7977796b51cb312066639ef3bb90178 SHA256 55cc252be1fcef66028a6fc96248052007f7ffafc5d3fff1414b073d55dd7915
+EBUILD povray-3.7.0_beta35.ebuild 4536 RMD160 dc5dfb8fb546ea501af0918c01d20aae60ec89c3 SHA1 890d5254b49afffe2a65e3eb9b78029e692e7d44 SHA256 03ae50be1eddc6141f1b3c1000d8ba3e81d48263e01957084ecc8a95821b7985
+EBUILD povray-3.7.0_beta38.ebuild 4551 RMD160 941289b518e0e570f3e41bb444f6acd1602f9b79 SHA1 59ec22c03ba6893562af1d00f0685def9c0e9402 SHA256 c0b2ee0ffbcae4df5224a2ec13e139a565c5f0f903a1c528735c48453ffaf0fe
+MISC ChangeLog 16278 RMD160 25938b1509c0cd03680755e6d460736857c92505 SHA1 ae922a8a8416adc8b444a7a44120be8f5c4f4ae7 SHA256 45d166f55b31c7348802fa4172baf978032b6ce4f75fd2c861a2d3aff65d9159
 MISC metadata.xml 329 RMD160 9a8409749fb299cc185ff9a2ca652cfffe77ca2f SHA1 53bbc21317be841681161e836ea09f6340b75109 SHA256 8eafb1373ab7a91c0057026a1e12aa07acdb9830c2b1141140d381a5af4f62df
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.16 (GNU/Linux)
 
-iEYEARECAAYFAkzf9AAACgkQgAnW8HDreRZeEACaA81csZ1LNLP35t4GGhzbXNbt
-eXoAn01Hk0EV64FmIJibyiRGKGhfxrCh
-=fnt8
+iEYEARECAAYFAkzf9PkACgkQgAnW8HDreRb+TgCgxi6iEXcPdnjOIUx18vnrKF5R
+hJ8An1s0ajjQZqGo4WDMUXs/eu+s76Rl
+=NZsO
 -----END PGP SIGNATURE-----
diff --git a/media-gfx/povray/povray-3.6.1-r4.ebuild b/media-gfx/povray/povray-3.6.1-r4.ebuild
index cf931b6c610f..53e2afc2928a 100644
--- a/media-gfx/povray/povray-3.6.1-r4.ebuild
+++ b/media-gfx/povray/povray-3.6.1-r4.ebuild
@@ -1,6 +1,6 @@
 # Copyright 1999-2010 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/media-gfx/povray/povray-3.6.1-r4.ebuild,v 1.10 2010/08/13 10:45:28 jlec Exp $
+# $Header: /var/cvsroot/gentoo-x86/media-gfx/povray/povray-3.6.1-r4.ebuild,v 1.11 2010/11/14 14:40:52 jlec Exp $
 
 inherit flag-o-matic eutils autotools
 
@@ -19,6 +19,7 @@ DEPEND="media-libs/libpng
 	sys-libs/zlib
 	X? ( x11-libs/libXaw )
 	svga? ( media-libs/svgalib )"
+RDEPEND="${DEPEND}"
 
 src_unpack() {
 	unpack ${A}
@@ -65,8 +66,7 @@ src_compile() {
 		COMPILED_BY="Portage (Gentoo `uname`) on `hostname -f`" \
 		$(use_with svga) \
 		$(use_with tiff) \
-		$(use_with X) \
-		|| die
+		$(use_with X)
 
 	emake || die
 }
diff --git a/media-gfx/povray/povray-3.7.0_beta35.ebuild b/media-gfx/povray/povray-3.7.0_beta35.ebuild
index 016ea983f9df..bd88243712b3 100644
--- a/media-gfx/povray/povray-3.7.0_beta35.ebuild
+++ b/media-gfx/povray/povray-3.7.0_beta35.ebuild
@@ -1,6 +1,6 @@
 # Copyright 1999-2010 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/media-gfx/povray/povray-3.7.0_beta35.ebuild,v 1.3 2010/06/01 12:58:33 lavajoe Exp $
+# $Header: /var/cvsroot/gentoo-x86/media-gfx/povray/povray-3.7.0_beta35.ebuild,v 1.4 2010/11/14 14:40:52 jlec Exp $
 
 inherit eutils autotools flag-o-matic versionator
 
@@ -28,6 +28,7 @@ DEPEND="media-libs/libpng
 	sys-libs/zlib
 	X? ( x11-libs/libXaw )
 	>=dev-libs/boost-1.36"
+RDEPEND="${DEPEND}"
 
 S="${WORKDIR}/${PN}-${MY_PV}"
 
@@ -90,8 +91,7 @@ src_compile() {
 		COMPILED_BY="Portage (Gentoo `uname`) on `hostname -f`" \
 		$(use_with tiff libtiff) \
 		$(use_with X x) \
-		--disable-strip \
-		|| die
+		--disable-strip
 
 	emake || die
 }
diff --git a/media-gfx/povray/povray-3.7.0_beta38.ebuild b/media-gfx/povray/povray-3.7.0_beta38.ebuild
index 896dd0217b5d..0db30ac8b70b 100644
--- a/media-gfx/povray/povray-3.7.0_beta38.ebuild
+++ b/media-gfx/povray/povray-3.7.0_beta38.ebuild
@@ -1,6 +1,6 @@
 # Copyright 1999-2010 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/media-gfx/povray/povray-3.7.0_beta38.ebuild,v 1.3 2010/11/14 14:36:43 jlec Exp $
+# $Header: /var/cvsroot/gentoo-x86/media-gfx/povray/povray-3.7.0_beta38.ebuild,v 1.4 2010/11/14 14:40:52 jlec Exp $
 
 EAPI="3"
 
@@ -35,6 +35,7 @@ DEPEND="
 	mkl? ( sci-libs/mkl )
 	tiff? ( >=media-libs/tiff-3.6.1 )
 	X? ( media-libs/libsdl )"
+RDEPEND="${DEPEND}"
 
 S="${WORKDIR}/${PN}-${MY_PV}"
 
@@ -98,7 +99,7 @@ src_configure() {
 		--disable-strip \
 		--disable-optimiz \
 		--disable-optimiz-arch \
-		--with-boost-libdir=${EPREFIX}/usr/$(get_libdir)
+		--with-boost-libdir="${EPREFIX}"/usr/$(get_libdir)
 }
 
 src_test() {