diff options
| author |   Sam James <sam@gentoo.org> | 2021-08-13 02:42:46 +0100 |
|---|---|---|
| committer | Sam James <sam@gentoo.org> | 2021-08-16 03:12:08 +0100 |
| commit | 28155dfc3ce5d7f5d9f19fe0239a27eaab29cccb (patch) | |
| tree | 8ec0a39d676907dc5afda9523472a68ea7ede9d5 /metadata | |
| parent | metadata/install-qa-check.d: only trigger on tmpfiles in forbidden location (diff) | |
| download | gentoo-28155dfc3ce5d7f5d9f19fe0239a27eaab29cccb.tar.gz gentoo-28155dfc3ce5d7f5d9f19fe0239a27eaab29cccb.tar.bz2 gentoo-28155dfc3ce5d7f5d9f19fe0239a27eaab29cccb.zip | |
metadata/install-qa-check.d: add exemptions for some packages wrt inherit
Both sys-apps/systemd and sys-libs/pam need to install some files
to these directories without inheriting the eclass.
For future work, we should have a standardised way on opting
out of installed files QA checks, but other QA checks are
already suffering from this issue.
See: https://archives.gentoo.org/gentoo-dev/message/0a96793036a4fdd9ac311a46950d7e7b
Signed-off-by: Sam James <sam@gentoo.org>
Diffstat (limited to 'metadata')
| -rw-r--r-- | metadata/install-qa-check.d/60tmpfiles-paths | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/metadata/install-qa-check.d/60tmpfiles-paths b/metadata/install-qa-check.d/60tmpfiles-paths index 5ef56885ebe7..81286de584a2 100644 --- a/metadata/install-qa-check.d/60tmpfiles-paths +++ b/metadata/install-qa-check.d/60tmpfiles-paths @@ -30,6 +30,14 @@ tmpfiles_check() { return fi + # It's okay for some packages to do this because of circular dependencies and such + # See: https://archives.gentoo.org/gentoo-dev/message/0a96793036a4fdd9ac311a46950d7e7b + # TODO: Standardize some way of allowing ebuilds to opt-out of checks like this + local package=${CATEGORY}/${PN} + if [[ ${package} == "sys-apps/systemd" || ${package} == "sys-libs/pam" ]] ; then + return + fi + if [[ -d "${ED}"/usr/lib/tmpfiles.d/ ]] ; then eqawarn "QA Notice: package is installing tmpfiles without inheriting tmpfiles.eclass!" eqawarn "Packages must inherit tmpfiles.eclass then call tmpfiles_process in pkg_postinst." |