aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrei Horodniceanu <a.horodniceanu@proton.me>2024-07-06 18:15:38 +0300
committerAndrei Horodniceanu <a.horodniceanu@proton.me>2024-07-06 18:43:41 +0300
commitf72da9c5e7b691f145a65839f3e9b0faf8fc67f6 (patch)
treee2790f3cca032c582ba7eb627c72b639ec6ed394
parentdmd-r1.eclass: trivial typo fixes in comments (diff)
downloaddlang-f72da9c5e7b691f145a65839f3e9b0faf8fc67f6.tar.gz
dlang-f72da9c5e7b691f145a65839f3e9b0faf8fc67f6.tar.bz2
dlang-f72da9c5e7b691f145a65839f3e9b0faf8fc67f6.zip
dmd-r1.eclass: clarify dependency on stdlib of host compiler
The previous comment, saying that dmd doesn't link the standard lib of the host compiler, is plain wrong, it always does. The only particularity is that dmd doesn't seem to need phobos but it does need druntime. Regardless, a RDEPEND on the host compiler is needed. Another comment has been added trying to describe the reason why DLANG_DEPS should be present in DEPEND. My current understanding is that since the compiler needs to link libraries from SYSROOT (druntime and phobos) to produce the CHOST dmd executable then those libraries should be listed in DEPEND. I'm not 100% sure though. Signed-off-by: Andrei Horodniceanu <a.horodniceanu@proton.me>
-rw-r--r--eclass/dmd-r1.eclass6
1 files changed, 3 insertions, 3 deletions
diff --git a/eclass/dmd-r1.eclass b/eclass/dmd-r1.eclass
index e34af81..49ec257 100644
--- a/eclass/dmd-r1.eclass
+++ b/eclass/dmd-r1.eclass
@@ -85,10 +85,10 @@ IDEPEND=">=app-eselect/eselect-dlang-20140709"
BDEPEND="!selfhost? ( ${DLANG_DEPS} )"
# We don't need anything in DEPEND, curl is dl-opened
# so it belongs in RDEPEND.
+#
+# Thinking about this more ${DLANG_DEPS} should probably go in DEPEND. I
+# want, however, to test this before making the fix.
#DEPEND=
-# Since 2.107.0, dmd links the standard library of the host
-# compiler. Since this eclass is only used by >=dmd-2.107.0-r1 the
-# dependency is added unconditionally.
RDEPEND="
${IDEPEND}
net-misc/curl[${MULTILIB_USEDEP}]